This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
Be nice(r) when no arguments given #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a standalone install `persistgraphql` gives
> Usage: persistgraphql input_file [output_file]
(node:46389) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be one of type string, Buffer, or URL. Received type undefined
at Object.fs.stat (fs.js:884:3)
at /usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:45:16
at new Promise (<anonymous>)
at Function.ExtractGQL.isDirectory (/usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:44:16)
at /usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:139:24
at new Promise (<anonymous>)
at ExtractGQL.readInputPath (/usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:138:16)
at /usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:129:19
at new Promise (<anonymous>)
at ExtractGQL.processInputPath (/usr/local/lib/node_modules/persistgraphql/lib/src/ExtractGQL.js:128:16)
|
@clemens-tolboom: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
ghost
added
the
Credits to @Aides359 from apollographql#31
|
Checking with #31 I only fixed the standalone variant. We need something similar as done in https://github.com/apollographql/persistgraphql/pull/31/files#diff-5c01c4c7bd17ea252db030eb6f9990b7R61 Added to this PR #63. Hope @Aides359 can get some credits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a standalone install
persistgraphqlgives a stack dumpWith the patch
which is as expected.